Commit fa376ac1 authored by Animesh Manna's avatar Animesh Manna Committed by Ville Syrjälä
Browse files

drm/i915/panelreplay: Panel replay workaround with VRR 



Panel Replay VSC SDP not getting sent when VRR is enabled
and W1 and W2 are 0. So Program Set Context Latency in
TRANS_SET_CONTEXT_LATENCY register to at least a value of 1.
The same is applicable for PSR1/PSR2 as well.

HSD: 14015406119

v1: Initial version.
v2: Update timings stored in adjusted_mode struct. [Ville]
v3: Add WA in compute_config(). [Ville]
v4:
- Add DISPLAY_VER() check and improve code comment. [Rodrigo]
- Introduce centralized intel_crtc_vblank_delay(). [Ville]
v5: Move to crtc_compute_config(). [Ville]
v6: Restrict DISPLAY_VER till 14. [Mitul]
v7:
- Corrected code-comment. [Mitul]
- dev_priv local variable removed. [Jani]
v8: Introduce late_compute_config() which will take care late
vblank-delay adjustment. [Ville]
v9: Implementation simplified and split into multiple patches.
v10:
- Split vrr changes and use struct intel_display in DISPLAY_VER(). [Ankit]
- Use for_each_new_intel_connector_in_state(). [Jani]
v11: Remove loop and use flipline instead of vrr.enable flag. [Ville]
v12:
- Use intel_Vrr_possible helper.
- Correct flag check for flipline.
v13:
- Refactor workaround [Jonathan]
- Drop the comment around woraround number. [Ville]

Signed-off-by: default avatarAnimesh Manna <animesh.manna@intel.com>
Signed-off-by: default avatarMitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Reviewed-by: default avatarJonathan Cavitt <jonathan.cavitt@intel.com>
[vsyrjala: Make adjusted_modeg const, and drop redundant parens]
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241010040503.1795399-4-mitulkumar.ajitkumar.golani@intel.com
parent 96abbed9

drivers/gpu/drm/i915/display/intel_display.c

+16 −0
Original line number Diff line number Diff line
@@ -2609,13 +2609,29 @@ static int intel_crtc_compute_pipe_mode(struct intel_crtc_state *crtc_state) 
	return 0;

}



static bool intel_crtc_needs_wa_14015401596(struct intel_crtc_state *crtc_state)

{

	struct intel_display *display = to_intel_display(crtc_state);

	const struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;



	return intel_vrr_possible(crtc_state) && crtc_state->has_psr &&

		adjusted_mode->crtc_vblank_start == adjusted_mode->crtc_vdisplay &&

		IS_DISPLAY_VER(display, 13, 14);

}



static int intel_crtc_compute_config(struct intel_atomic_state *state,

				     struct intel_crtc *crtc)

{

	struct intel_crtc_state *crtc_state =

		intel_atomic_get_new_crtc_state(state, crtc);

	struct drm_display_mode *adjusted_mode =

		&crtc_state->hw.adjusted_mode;

	int ret;



	/* Wa_14015401596 */

	if (intel_crtc_needs_wa_14015401596(crtc_state))

		adjusted_mode->crtc_vblank_start += 1;



	ret = intel_dpll_crtc_compute_clock(state, crtc);

	if (ret)

		return ret;