Commit fa7dfeae authored by FUJITA Tomonori's avatar FUJITA Tomonori Committed by Jakub Kicinski
Browse files

net: phy: qt2025: Fix warning: unused import DeviceId 



Fix the following warning when the driver is compiled as built-in:

      warning: unused import: `DeviceId`
      --> drivers/net/phy/qt2025.rs:18:5
      |
   18 |     DeviceId, Driver,
      |     ^^^^^^^^
      |
      = note: `#[warn(unused_imports)]` on by default

device_table in module_phy_driver macro is defined only when the
driver is built as a module. Use phy::DeviceId in the macro instead of
importing `DeviceId` since `phy` is always used.

Fixes: fd3eaad8 ("net: phy: add Applied Micro QT2025 PHY driver")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202409190717.i135rfVo-lkp@intel.com/


Reviewed-by: default avatarAlice Ryhl <aliceryhl@google.com>
Reviewed-by: default avatarTrevor Gross <tmgross@umich.edu>
Signed-off-by: default avatarFUJITA Tomonori <fujita.tomonori@gmail.com>
Reviewed-by: default avatarFiona Behrens <me@kloenk.dev>
Acked-by: default avatarMiguel Ojeda <ojeda@kernel.org>
Link: https://patch.msgid.link/20240926121404.242092-1-fujita.tomonori@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a1e40ac5

drivers/net/phy/qt2025.rs

+2 −2
Original line number Diff line number Diff line
@@ -15,7 +15,7 @@ 
use kernel::net::phy::{

    self,

    reg::{Mmd, C45},

    DeviceId, Driver,

    Driver,

};

use kernel::prelude::*;

use kernel::sizes::{SZ_16K, SZ_8K};
@@ -23,7 +23,7 @@ 
kernel::module_phy_driver! {

    drivers: [PhyQT2025],

    device_table: [

        DeviceId::new_with_driver::<PhyQT2025>(),

        phy::DeviceId::new_with_driver::<PhyQT2025>(),

    ],

    name: "qt2025_phy",

    author: "FUJITA Tomonori <fujita.tomonori@gmail.com>",