Commit fa8fb60d authored by lynn's avatar lynn Committed by Joerg Roedel
Browse files

iommu/iova: Add NULL check in iova_magazine_free()



When iova_domain_init_rcaches() fails to allocate an iova_magazine
during the initialization of per-cpu rcaches, it jumps to out_err and
calls free_iova_rcaches() for cleanup.

In free_iova_rcaches(), the code iterates through all possible CPUs to
free both cpu_rcache->loaded and cpu_rcache->prev. However, if the
original allocation failed mid-way through the CPU loop, the pointers
for the remaining CPUs remain NULL.

Since kmem_cache_free() does not explicitly handle NULL pointers like
kfree() does, passing these NULL pointers leads to a kernel paging
request fault.

Add a NULL check in iova_magazine_free() to safely handle partially
initialized rcaches in error paths.

Signed-off-by: default avatarlynn <liulynn@google.com>
Signed-off-by: default avatarJoerg Roedel <joerg.roedel@amd.com>
parent 199036ae
Loading
Loading
Loading
Loading
+2 −1
Original line number Diff line number Diff line
@@ -611,6 +611,7 @@ static struct iova_magazine *iova_magazine_alloc(gfp_t flags)

static void iova_magazine_free(struct iova_magazine *mag)
{
	if (mag)
		kmem_cache_free(iova_magazine_cache, mag);
}