Unverified Commit fae88e03 authored by David Laight's avatar David Laight Committed by Andi Shyti
Browse files

drivers/i2c/busses: use min() instead of min_t() 



min_t(u8, a, b) casts both its arguments to u8 potentially discarding
signifinact bits.
Use min(a, b) instead as it cannot discard significant bits.

Detected by an extra check added to min_t().

Signed-off-by: default avatarDavid Laight <david.laight.linux@gmail.com>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20251119224140.8616-21-david.laight.linux@gmail.com
parent 949f647e

drivers/i2c/busses/i2c-designware-master.c

+1 −1
Original line number Diff line number Diff line
@@ -575,7 +575,7 @@ i2c_dw_recv_len(struct dw_i2c_dev *dev, u8 len) 
	 * after receiving the first byte.

	 */

	len += (flags & I2C_CLIENT_PEC) ? 2 : 1;

	dev->tx_buf_len = len - min_t(u8, len, dev->rx_outstanding);

	dev->tx_buf_len = len - min(len, dev->rx_outstanding);

	msgs[dev->msg_read_idx].len = len;

	msgs[dev->msg_read_idx].flags &= ~I2C_M_RECV_LEN;