Commit fae8cab4 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Hans Verkuil
Browse files

media: platform: synopsys: hdmirx: Fix 64-bit division for 32-bit targets 



The build fails for 32-bit targets with:

  arm-linux-gnueabi-ld: drivers/media/platform/synopsys/hdmirx/snps_hdmirx.o: in function `hdmirx_get_timings':
  snps_hdmirx.c:(.text.hdmirx_get_timings+0x46c): undefined reference to `__aeabi_uldivmod'

bt->pixelclock is __u64, which causes the compiler to emit a libcall for
64-bit division. Use the optimized kernel helper, div_u64(), to resolve
this.

Fixes: 7b59b132 ("media: platform: synopsys: Add support for HDMI input driver")
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
parent 143d7558

drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c

+2 −1
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ 
#include <linux/interrupt.h>

#include <linux/irq.h>

#include <linux/mfd/syscon.h>

#include <linux/math64.h>

#include <linux/module.h>

#include <linux/of.h>

#include <linux/of_platform.h>
@@ -291,7 +292,7 @@ static void hdmirx_get_timings(struct snps_hdmirx_dev *hdmirx_dev, 
	hfp = htotal - hact - hs - hbp;

	vfp = vtotal - vact - vs - vbp;



	fps = (bt->pixelclock + (htotal * vtotal) / 2) / (htotal * vtotal);

	fps = div_u64(bt->pixelclock + (htotal * vtotal) / 2, htotal * vtotal);

	bt->width = hact;

	bt->height = vact;

	bt->hfrontporch = hfp;