Commit faeebafe authored by Dmitry Baryshkov's avatar Dmitry Baryshkov
Browse files

drm/panel-edp: add fat warning against adding new panel compatibles 



Add a fat warning against adding new panel compatibles to the panel-edp
driver. All new users of the eDP panels are supposed to use the generic
"edp-panel" compatible device on the AUX bus. The remaining compatibles
are either used by the existing DT or were used previously and are
retained for backwards compatibility.

Suggested-by: default avatarDoug Anderson <dianders@chromium.org>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240614-edp-panel-drop-v4-1-4e0a112eec46@linaro.org


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent 7758685b

drivers/gpu/drm/panel/panel-edp.c

+18 −1
Original line number Diff line number Diff line
@@ -1762,7 +1762,24 @@ static const struct of_device_id platform_of_match[] = { 
	{

		/* Must be first */

		.compatible = "edp-panel",

	}, {

	},

	/*

	 * Do not add panels to the list below unless they cannot be handled by

	 * the generic edp-panel compatible.

	 *

	 * The only two valid reasons are:

	 * - Because of the panel issues (e.g. broken EDID or broken

	 *   identification).

	 * - Because the eDP drivers didn't wire up the AUX bus properly.

	 *   NOTE that, though this is a marginally valid reason,

	 *   some justification needs to be made for why the platform can't

	 *   wire up the AUX bus properly.

	 *

	 * In all other cases the platform should use the aux-bus and declare

	 * the panel using the 'edp-panel' compatible as a device on the AUX

	 * bus.

	 */

	{

		.compatible = "auo,b101ean01",

		.data = &auo_b101ean01,

	}, {