Commit fb14ef46 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Herbert Xu
Browse files

crypto: virtio - Erase some sensitive memory when it is freed 



virtcrypto_clear_request() does the same as the code here, but uses
kfree_sensitive() for one of the free operation.

So, better safe than sorry, use virtcrypto_clear_request() directly to
save a few lines of code and cleanly free the memory.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tested-by: default avatarLei Yang <leiyang@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 20238d49

drivers/crypto/virtio/virtio_crypto_core.c

+2 −4
Original line number Diff line number Diff line
@@ -480,10 +480,8 @@ static void virtcrypto_free_unused_reqs(struct virtio_crypto *vcrypto) 


	for (i = 0; i < vcrypto->max_data_queues; i++) {

		vq = vcrypto->data_vq[i].vq;

		while ((vc_req = virtqueue_detach_unused_buf(vq)) != NULL) {

			kfree(vc_req->req_data);

			kfree(vc_req->sgs);

		}

		while ((vc_req = virtqueue_detach_unused_buf(vq)) != NULL)

			virtcrypto_clear_request(vc_req);

		cond_resched();

	}

}