Commit fb1f4568 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: core: Disable timestamp functionality if not supported 



Some Kioxia UFS 4 devices do not support the qTimestamp attribute.  Set
the UFS_DEVICE_QUIRK_NO_TIMESTAMP_SUPPORT for these devices such that no
error messages appear in the kernel log about failures to set the
qTimestamp attribute.

Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Reviewed-by: default avatarAvri Altman <avri.altman@sandisk.com>
Tested-by: Nitin Rawat <quic_nitirawa@quicinc.com> # on SM8650-QRD
Reviewed-by: default avatarNitin Rawat <quic_nitirawa@quicinc.com>
Reviewed-by: default avatarPeter Wang <peter.wang@mediatek.com>
Reviewed-by: default avatarManivannan Sadhasivam <mani@kernel.org>
Message-ID: <20250909190614.3531435-1-bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f2d81dd6

drivers/ufs/core/ufshcd.c

+5 −1
Original line number Diff line number Diff line
@@ -316,6 +316,9 @@ static const struct ufs_dev_quirk ufs_fixups[] = { 
	{ .wmanufacturerid = UFS_VENDOR_TOSHIBA,

	  .model = "THGLF2G9D8KBADG",

	  .quirk = UFS_DEVICE_QUIRK_PA_TACTIVATE },

	{ .wmanufacturerid = UFS_VENDOR_TOSHIBA,

	  .model = "THGJFJT1E45BATP",

	  .quirk = UFS_DEVICE_QUIRK_NO_TIMESTAMP_SUPPORT },

	{}

};
@@ -8778,7 +8781,8 @@ static void ufshcd_set_timestamp_attr(struct ufs_hba *hba) 
	struct ufs_dev_info *dev_info = &hba->dev_info;

	struct utp_upiu_query_v4_0 *upiu_data;



	if (dev_info->wspecversion < 0x400)

	if (dev_info->wspecversion < 0x400 ||

	    hba->dev_quirks & UFS_DEVICE_QUIRK_NO_TIMESTAMP_SUPPORT)

		return;



	ufshcd_dev_man_lock(hba);

include/ufs/ufs_quirks.h

+3 −0
Original line number Diff line number Diff line
@@ -113,4 +113,7 @@ struct ufs_dev_quirk { 
 */

#define UFS_DEVICE_QUIRK_PA_HIBER8TIME          (1 << 12)



/* Some UFS 4 devices do not support the qTimestamp attribute */

#define UFS_DEVICE_QUIRK_NO_TIMESTAMP_SUPPORT	(1 << 13)



#endif /* UFS_QUIRKS_H_ */