Commit fb211160 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Vinod Koul
Browse files

phy: broadcom: ns-usb3: Fix Wvoid-pointer-to-enum-cast warning (again) 



"family" is an enum, thus cast of pointer on 64-bit compile test with
clang W=1 causes:

  phy-bcm-ns-usb3.c:206:17: error: cast to smaller integer type 'enum bcm_ns_family' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]

This was already fixed in commit bd6e74a2 ("phy: broadcom: ns-usb3:
fix Wvoid-pointer-to-enum-cast warning") but then got bad in commit
21bf6fc4 ("phy: Use device_get_match_data()").

Note that after various discussions the preferred cast is via "unsigned
long", not "uintptr_t".

Fixes: 21bf6fc4 ("phy: Use device_get_match_data()")
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20251224115533.154162-2-krzysztof.kozlowski@oss.qualcomm.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent b246caa6

drivers/phy/broadcom/phy-bcm-ns-usb3.c

+1 −1
Original line number Diff line number Diff line
@@ -203,7 +203,7 @@ static int bcm_ns_usb3_mdio_probe(struct mdio_device *mdiodev) 
	usb3->dev = dev;

	usb3->mdiodev = mdiodev;



	usb3->family = (enum bcm_ns_family)device_get_match_data(dev);

	usb3->family = (unsigned long)device_get_match_data(dev);



	syscon_np = of_parse_phandle(dev->of_node, "usb3-dmp-syscon", 0);

	err = of_address_to_resource(syscon_np, 0, &res);