Commit fb6009a2 authored by Sam Winchenbach's avatar Sam Winchenbach Committed by Jonathan Cameron
Browse files

iio: filter: admv8818: fix integer overflow 



HZ_PER_MHZ is only unsigned long. This math overflows, leading to
incorrect results.

Fixes: f34fe888 ("iio:filter:admv8818: add support for ADMV8818")
Signed-off-by: default avatarSam Winchenbach <swinchenbach@arka.org>
Link: https://patch.msgid.link/20250328174831.227202-4-sam.winchenbach@framepointer.org


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent ef0ce24f

drivers/iio/filter/admv8818.c

+1 −1
Original line number Diff line number Diff line
@@ -154,7 +154,7 @@ static int __admv8818_hpf_select(struct admv8818_state *st, u64 freq) 
	}



	/* Close HPF frequency gap between 12 and 12.5 GHz */

	if (freq >= 12000 * HZ_PER_MHZ && freq <= 12500 * HZ_PER_MHZ) {

	if (freq >= 12000ULL * HZ_PER_MHZ && freq < 12500ULL * HZ_PER_MHZ) {

		hpf_band = 3;

		hpf_step = 15;

	}