Commit fb62d675 authored by Qi Liu's avatar Qi Liu Committed by Will Deacon
Browse files

drivers/perf: convert sysfs sprintf family to sysfs_emit 



sprintf does not know the PAGE_SIZE maximum of the temporary buffer
used for sysfs content and it's possible to overrun the buffer length.

Use sysfs_emit() function to ensures that no overrun is done.

Signed-off-by: default avatarQi Liu <liuqi115@huawei.com>
Link: https://lore.kernel.org/r/1616148273-16374-4-git-send-email-liuqi115@huawei.com


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent 9ec9f9cf

drivers/perf/arm_dmc620_pmu.c

+1 −1
Original line number Diff line number Diff line
@@ -113,7 +113,7 @@ dmc620_pmu_event_show(struct device *dev, 


	eattr = container_of(attr, typeof(*eattr), attr);



	return sprintf(page, "event=0x%x,clkdiv2=0x%x\n", eattr->eventid, eattr->clkdiv2);

	return sysfs_emit(page, "event=0x%x,clkdiv2=0x%x\n", eattr->eventid, eattr->clkdiv2);

}



#define DMC620_PMU_EVENT_ATTR(_name, _eventid, _clkdiv2)		\

drivers/perf/arm_smmuv3_pmu.c

+1 −1
Original line number Diff line number Diff line
@@ -506,7 +506,7 @@ static ssize_t smmu_pmu_event_show(struct device *dev, 


	pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr);



	return sprintf(page, "event=0x%02llx\n", pmu_attr->id);

	return sysfs_emit(page, "event=0x%02llx\n", pmu_attr->id);

}



#define SMMU_EVENT_ATTR(name, config) \

drivers/perf/fsl_imx8_ddr_perf.c

+2 −2
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ static ssize_t ddr_perf_identifier_show(struct device *dev, 
{

	struct ddr_pmu *pmu = dev_get_drvdata(dev);



	return sprintf(page, "%s\n", pmu->devtype_data->identifier);

	return sysfs_emit(page, "%s\n", pmu->devtype_data->identifier);

}



static umode_t ddr_perf_identifier_attr_visible(struct kobject *kobj,
@@ -219,7 +219,7 @@ ddr_pmu_event_show(struct device *dev, struct device_attribute *attr, 
	struct perf_pmu_events_attr *pmu_attr;



	pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr);

	return sprintf(page, "event=0x%02llx\n", pmu_attr->id);

	return sysfs_emit(page, "event=0x%02llx\n", pmu_attr->id);

}



#define IMX8_DDR_PMU_EVENT_ATTR(_name, _id)				\

drivers/perf/hisilicon/hisi_uncore_pmu.c

+3 −3
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ ssize_t hisi_format_sysfs_show(struct device *dev, 


	eattr = container_of(attr, struct dev_ext_attribute, attr);



	return sprintf(buf, "%s\n", (char *)eattr->var);

	return sysfs_emit(buf, "%s\n", (char *)eattr->var);

}

EXPORT_SYMBOL_GPL(hisi_format_sysfs_show);
@@ -47,7 +47,7 @@ ssize_t hisi_event_sysfs_show(struct device *dev, 


	eattr = container_of(attr, struct dev_ext_attribute, attr);



	return sprintf(page, "config=0x%lx\n", (unsigned long)eattr->var);

	return sysfs_emit(page, "config=0x%lx\n", (unsigned long)eattr->var);

}

EXPORT_SYMBOL_GPL(hisi_event_sysfs_show);
@@ -59,7 +59,7 @@ ssize_t hisi_cpumask_sysfs_show(struct device *dev, 
{

	struct hisi_pmu *hisi_pmu = to_hisi_pmu(dev_get_drvdata(dev));



	return sprintf(buf, "%d\n", hisi_pmu->on_cpu);

	return sysfs_emit(buf, "%d\n", hisi_pmu->on_cpu);

}

EXPORT_SYMBOL_GPL(hisi_cpumask_sysfs_show);

drivers/perf/qcom_l2_pmu.c

+1 −1
Original line number Diff line number Diff line
@@ -676,7 +676,7 @@ static ssize_t l2cache_pmu_event_show(struct device *dev, 
	struct perf_pmu_events_attr *pmu_attr;



	pmu_attr = container_of(attr, struct perf_pmu_events_attr, attr);

	return sprintf(page, "event=0x%02llx\n", pmu_attr->id);

	return sysfs_emit(page, "event=0x%02llx\n", pmu_attr->id);

}



#define L2CACHE_EVENT_ATTR(_name, _id)					     \