Unverified Commit fb6ec1d2 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Mark Brown
Browse files

ASoC: mediatek: mt6358: Remove unused functions 



The functions:
  mt6358_mtkaif_calibration_disable()
  mt6358_mtkaif_calibration_enable()
  mt6358_set_mtkaif_calibration_phase()
were added in the 2019
commit 6a8d4198 ("ASoC: mediatek: mt6358: add codec driver")

but never used.

Remove them.

This leaves mt6358_set_dcxo(), mt6358_set_clksq(),
mt6358_set_aud_global_bias(), also unused.

Remove them.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Link: https://patch.msgid.link/20250128005243.295977-1-linux@treblig.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a05143a8

sound/soc/codecs/mt6358.c

+0 −104
Original line number Diff line number Diff line
@@ -162,47 +162,6 @@ static void capture_gpio_reset(struct mt6358_priv *priv) 
			   0xf << 12, 0x0);

}



/* use only when not govern by DAPM */

static int mt6358_set_dcxo(struct mt6358_priv *priv, bool enable)

{

	regmap_update_bits(priv->regmap, MT6358_DCXO_CW14,

			   0x1 << RG_XO_AUDIO_EN_M_SFT,

			   (enable ? 1 : 0) << RG_XO_AUDIO_EN_M_SFT);

	return 0;

}



/* use only when not govern by DAPM */

static int mt6358_set_clksq(struct mt6358_priv *priv, bool enable)

{

	/* audio clk source from internal dcxo */

	regmap_update_bits(priv->regmap, MT6358_AUDENC_ANA_CON6,

			   RG_CLKSQ_IN_SEL_TEST_MASK_SFT,

			   0x0);



	/* Enable/disable CLKSQ 26MHz */

	regmap_update_bits(priv->regmap, MT6358_AUDENC_ANA_CON6,

			   RG_CLKSQ_EN_MASK_SFT,

			   (enable ? 1 : 0) << RG_CLKSQ_EN_SFT);

	return 0;

}



/* use only when not govern by DAPM */

static int mt6358_set_aud_global_bias(struct mt6358_priv *priv, bool enable)

{

	regmap_update_bits(priv->regmap, MT6358_AUDDEC_ANA_CON13,

			   RG_AUDGLB_PWRDN_VA28_MASK_SFT,

			   (enable ? 0 : 1) << RG_AUDGLB_PWRDN_VA28_SFT);

	return 0;

}



/* use only when not govern by DAPM */

static int mt6358_set_topck(struct mt6358_priv *priv, bool enable)

{

	regmap_update_bits(priv->regmap, MT6358_AUD_TOP_CKPDN_CON0,

			   0x0066, enable ? 0x0 : 0x66);

	return 0;

}



static int mt6358_mtkaif_tx_enable(struct mt6358_priv *priv)

{

	switch (priv->mtkaif_protocol) {
@@ -252,69 +211,6 @@ static int mt6358_mtkaif_tx_disable(struct mt6358_priv *priv) 
	return 0;

}



int mt6358_mtkaif_calibration_enable(struct snd_soc_component *cmpnt)

{

	struct mt6358_priv *priv = snd_soc_component_get_drvdata(cmpnt);



	playback_gpio_set(priv);

	capture_gpio_set(priv);

	mt6358_mtkaif_tx_enable(priv);



	mt6358_set_dcxo(priv, true);

	mt6358_set_aud_global_bias(priv, true);

	mt6358_set_clksq(priv, true);

	mt6358_set_topck(priv, true);



	/* set dat_miso_loopback on */

	regmap_update_bits(priv->regmap, MT6358_AUDIO_DIG_CFG,

			   RG_AUD_PAD_TOP_DAT_MISO2_LOOPBACK_MASK_SFT,

			   1 << RG_AUD_PAD_TOP_DAT_MISO2_LOOPBACK_SFT);

	regmap_update_bits(priv->regmap, MT6358_AUDIO_DIG_CFG,

			   RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_MASK_SFT,

			   1 << RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_SFT);

	return 0;

}

EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_enable);



int mt6358_mtkaif_calibration_disable(struct snd_soc_component *cmpnt)

{

	struct mt6358_priv *priv = snd_soc_component_get_drvdata(cmpnt);



	/* set dat_miso_loopback off */

	regmap_update_bits(priv->regmap, MT6358_AUDIO_DIG_CFG,

			   RG_AUD_PAD_TOP_DAT_MISO2_LOOPBACK_MASK_SFT,

			   0 << RG_AUD_PAD_TOP_DAT_MISO2_LOOPBACK_SFT);

	regmap_update_bits(priv->regmap, MT6358_AUDIO_DIG_CFG,

			   RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_MASK_SFT,

			   0 << RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_SFT);



	mt6358_set_topck(priv, false);

	mt6358_set_clksq(priv, false);

	mt6358_set_aud_global_bias(priv, false);

	mt6358_set_dcxo(priv, false);



	mt6358_mtkaif_tx_disable(priv);

	playback_gpio_reset(priv);

	capture_gpio_reset(priv);

	return 0;

}

EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_disable);



int mt6358_set_mtkaif_calibration_phase(struct snd_soc_component *cmpnt,

					int phase_1, int phase_2)

{

	struct mt6358_priv *priv = snd_soc_component_get_drvdata(cmpnt);



	regmap_update_bits(priv->regmap, MT6358_AUDIO_DIG_CFG,

			   RG_AUD_PAD_TOP_PHASE_MODE_MASK_SFT,

			   phase_1 << RG_AUD_PAD_TOP_PHASE_MODE_SFT);

	regmap_update_bits(priv->regmap, MT6358_AUDIO_DIG_CFG,

			   RG_AUD_PAD_TOP_PHASE_MODE2_MASK_SFT,

			   phase_2 << RG_AUD_PAD_TOP_PHASE_MODE2_SFT);

	return 0;

}

EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_calibration_phase);



/* dl pga gain */

enum {

	DL_GAIN_8DB = 0,

sound/soc/codecs/mt6358.h

+0 −4
Original line number Diff line number Diff line
@@ -2307,8 +2307,4 @@ enum { 
/* set only during init */

int mt6358_set_mtkaif_protocol(struct snd_soc_component *cmpnt,

			       int mtkaif_protocol);

int mt6358_mtkaif_calibration_enable(struct snd_soc_component *cmpnt);

int mt6358_mtkaif_calibration_disable(struct snd_soc_component *cmpnt);

int mt6358_set_mtkaif_calibration_phase(struct snd_soc_component *cmpnt,

					int phase_1, int phase_2);

#endif /* __MT6358_H__ */