Unverified Commit fb9ad244 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: ops: add correct range check for limiting volume 



Volume can have ranges that start with negative values, ex: -84dB to
+40dB. Apply correct range check in snd_soc_limit_volume before setting
the platform_max. Without this patch, for example setting a 0dB limit on
a volume range of -84dB to +40dB would fail.

Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Tested-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20231204124736.132185-2-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e238b68e

sound/soc/soc-ops.c

+1 −1
Original line number Diff line number Diff line
@@ -661,7 +661,7 @@ int snd_soc_limit_volume(struct snd_soc_card *card, 
	kctl = snd_soc_card_get_kcontrol(card, name);

	if (kctl) {

		struct soc_mixer_control *mc = (struct soc_mixer_control *)kctl->private_value;

		if (max <= mc->max) {

		if (max <= mc->max - mc->min) {

			mc->platform_max = max;

			ret = 0;

		}