Commit fbcbd66f authored by Ziyue Zhang's avatar Ziyue Zhang Committed by Bjorn Helgaas
Browse files

dt-bindings: PCI: qcom,pcie-sa8775p: Document 'link_down' reset



Each PCIe controller on SA8775P includes a 'link_down' reset line in
hardware. This patch documents the reset in the device tree binding.

The 'link_down' reset is used to forcefully bring down the PCIe link
layer, which is useful in scenarios such as link recovery after errors,
power management transitions, and hotplug events. Including this reset
line improves robustness and provides finer control over PCIe controller
behavior.

As the 'link_down' reset was omitted in the initial submission, it is now
being documented. While this reset is not required for most of the block's
basic functionality, and device trees lacking it will continue to function
correctly in most cases, it is necessary to ensure maximum robustness when
shutting down or recovering the PCIe core. Therefore, its inclusion is
justified despite the minor ABI change.

Signed-off-by: default avatarZiyue Zhang <ziyue.zhang@oss.qualcomm.com>
Signed-off-by: default avatarManivannan Sadhasivam <mani@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarRob Herring (Arm) <robh@kernel.org>
Reviewed-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Link: https://patch.msgid.link/20250718081718.390790-3-ziyue.zhang@oss.qualcomm.com
parent 51e78d97
Loading
Loading
Loading
Loading
+8 −3
Original line number Diff line number Diff line
@@ -66,11 +66,14 @@ properties:
      - const: global

  resets:
    maxItems: 1
    items:
      - description: PCIe controller reset
      - description: PCIe link down reset

  reset-names:
    items:
      - const: pci
      - const: link_down

required:
  - interconnects
@@ -166,8 +169,10 @@ examples:

            power-domains = <&gcc PCIE_0_GDSC>;

            resets = <&gcc GCC_PCIE_0_BCR>;
            reset-names = "pci";
            resets = <&gcc GCC_PCIE_0_BCR>,
                     <&gcc GCC_PCIE_0_LINK_DOWN_BCR>;
            reset-names = "pci",
                          "link_down";

            perst-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>;
            wake-gpios = <&tlmm 0 GPIO_ACTIVE_HIGH>;