Commit fbd401e9 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI: processor: idle: Redefine two functions as void 



Notice that acpi_processor_power_init() and acpi_processor_power_exit()
don't need to return any values because their callers don't check them
anyway, so redefine those functions as void.

While at it, rearrange the code in acpi_processor_power_init() to
reduce the indentation level, get rid of a redundant local variable
in that function, and rephrase a code comment in it.

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarMario Limonciello (AMD) <superm1@kernel.org>
parent 8a1b5d41

drivers/acpi/processor_idle.c

+19 −22
Original line number Diff line number Diff line
@@ -1400,47 +1400,45 @@ void acpi_processor_unregister_idle_driver(void) 
	cpuidle_unregister_driver(&acpi_idle_driver);

}



int acpi_processor_power_init(struct acpi_processor *pr)

void acpi_processor_power_init(struct acpi_processor *pr)

{

	int retval;

	struct cpuidle_device *dev;



	if (disabled_by_idle_boot_param())

		return 0;

		return;



	acpi_processor_cstate_first_run_checks();



	if (!acpi_processor_get_power_info(pr))

		pr->flags.power_setup_done = 1;



	if (pr->flags.power) {

	if (!pr->flags.power)

		return;



	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (!dev)

			return -ENOMEM;

		return;



	per_cpu(acpi_cpuidle_device, pr->id) = dev;



	acpi_processor_setup_cpuidle_dev(pr, dev);



		/* Register per-cpu cpuidle_device. Cpuidle driver

		 * must already be registered before registering device

	/*

	 * Register a cpuidle device for this CPU.  The cpuidle driver using

	 * this device is expected to be registered.

	 */

		retval = cpuidle_register_device(dev);

		if (retval) {



	if (cpuidle_register_device(dev)) {

		per_cpu(acpi_cpuidle_device, pr->id) = NULL;

		kfree(dev);

			return retval;

	}

}

	return 0;

}



int acpi_processor_power_exit(struct acpi_processor *pr)

void acpi_processor_power_exit(struct acpi_processor *pr)

{

	struct cpuidle_device *dev = per_cpu(acpi_cpuidle_device, pr->id);



	if (disabled_by_idle_boot_param())

		return 0;

		return;



	if (pr->flags.power) {

		cpuidle_unregister_device(dev);
@@ -1448,7 +1446,6 @@ int acpi_processor_power_exit(struct acpi_processor *pr) 
	}



	pr->flags.power_setup_done = 0;

	return 0;

}



MODULE_IMPORT_NS("ACPI_PROCESSOR_IDLE");

include/acpi/processor.h

+2 −2
Original line number Diff line number Diff line
@@ -419,8 +419,8 @@ static inline void acpi_processor_throttling_init(void) {} 
/* in processor_idle.c */

extern struct cpuidle_driver acpi_idle_driver;

#ifdef CONFIG_ACPI_PROCESSOR_IDLE

int acpi_processor_power_init(struct acpi_processor *pr);

int acpi_processor_power_exit(struct acpi_processor *pr);

void acpi_processor_power_init(struct acpi_processor *pr);

void acpi_processor_power_exit(struct acpi_processor *pr);

int acpi_processor_power_state_has_changed(struct acpi_processor *pr);

int acpi_processor_hotplug(struct acpi_processor *pr);

void acpi_processor_register_idle_driver(void);