Commit fbe56778 authored by Vinicius Costa Gomes's avatar Vinicius Costa Gomes Committed by Tony Nguyen
Browse files

igc: Simplify setting flags in the TX data descriptor 



We can re-use the IGC_SET_FLAG() macro to simplify setting some values
in the TX data descriptor. With the macro it's easier to get the
meaning of the operations.

Signed-off-by: default avatarVinicius Costa Gomes <vinicius.gomes@intel.com>
Tested-by: default avatarNaama Meir <naamax.meir@linux.intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 89cdf9d5

drivers/net/ethernet/intel/igc/igc_main.c

+4 −6
Original line number Diff line number Diff line
@@ -1299,14 +1299,12 @@ static void igc_tx_olinfo_status(struct igc_ring *tx_ring, 
	u32 olinfo_status = paylen << IGC_ADVTXD_PAYLEN_SHIFT;



	/* insert L4 checksum */

	olinfo_status |= (tx_flags & IGC_TX_FLAGS_CSUM) *

			  ((IGC_TXD_POPTS_TXSM << 8) /

			  IGC_TX_FLAGS_CSUM);

	olinfo_status |= IGC_SET_FLAG(tx_flags, IGC_TX_FLAGS_CSUM,

				      (IGC_TXD_POPTS_TXSM << 8));



	/* insert IPv4 checksum */

	olinfo_status |= (tx_flags & IGC_TX_FLAGS_IPV4) *

			  (((IGC_TXD_POPTS_IXSM << 8)) /

			  IGC_TX_FLAGS_IPV4);

	olinfo_status |= IGC_SET_FLAG(tx_flags, IGC_TX_FLAGS_IPV4,

				      (IGC_TXD_POPTS_IXSM << 8));



	tx_desc->read.olinfo_status = cpu_to_le32(olinfo_status);

}