Commit fc09ffd3 authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Alexandre Belloni
Browse files

i3c: mipi-i3c-hci: Change interrupt status prints to dev_dbg() 



Change interrupt status prints from local DBG() macro to dev_dbg() in
order to make it easier to enable them without needing to recompile code
with DEBUG defined.

While doing so, spell out the status register names as they are in the
specification to make it easier to differentiate between different
interrupt status registers.

Since dynamic debug prints can include the line number remove the "(in)"
and "(out)" markers from the PIO interrupt status prints.

Prefix the ring interrupt status print using "Ring %d" instead of "rh%d"
to make it uniform across all other prints showing the ring number.

Signed-off-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250827103009.243771-2-jarkko.nikula@linux.intel.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent ec011151

drivers/i3c/master/mipi-i3c-hci/core.c

+1 −1
Original line number Diff line number Diff line
@@ -553,7 +553,7 @@ static irqreturn_t i3c_hci_irq_handler(int irq, void *dev_id) 


	val = reg_read(INTR_STATUS);

	reg_write(INTR_STATUS, val);

	DBG("INTR_STATUS = %#x", val);

	dev_dbg(&hci->master.dev, "INTR_STATUS %#x", val);



	if (val)

		result = IRQ_HANDLED;

drivers/i3c/master/mipi-i3c-hci/dma.c

+2 −1
Original line number Diff line number Diff line
@@ -760,7 +760,8 @@ static bool hci_dma_irq_handler(struct i3c_hci *hci) 


		rh = &rings->headers[i];

		status = rh_reg_read(INTR_STATUS);

		DBG("rh%d status: %#x", i, status);

		dev_dbg(&hci->master.dev, "Ring %d: RH_INTR_STATUS %#x",

			i, status);

		if (!status)

			continue;

		rh_reg_write(INTR_STATUS, status);

drivers/i3c/master/mipi-i3c-hci/pio.c

+4 −3
Original line number Diff line number Diff line
@@ -986,7 +986,8 @@ static bool hci_pio_irq_handler(struct i3c_hci *hci) 


	spin_lock(&pio->lock);

	status = pio_reg_read(INTR_STATUS);

	DBG("(in) status: %#x/%#x", status, pio->enabled_irqs);

	dev_dbg(&hci->master.dev, "PIO_INTR_STATUS %#x/%#x",

		status, pio->enabled_irqs);

	status &= pio->enabled_irqs | STAT_LATENCY_WARNINGS;

	if (!status) {

		spin_unlock(&pio->lock);
@@ -1023,7 +1024,7 @@ static bool hci_pio_irq_handler(struct i3c_hci *hci) 
			pio->enabled_irqs &= ~STAT_CMD_QUEUE_READY;



	pio_reg_write(INTR_SIGNAL_ENABLE, pio->enabled_irqs);

	DBG("(out) status: %#x/%#x",

	dev_dbg(&hci->master.dev, "PIO_INTR_STATUS %#x/%#x",

		pio_reg_read(INTR_STATUS), pio_reg_read(INTR_SIGNAL_ENABLE));

	spin_unlock(&pio->lock);

	return true;