Commit fc48627b authored by Dave Chinner's avatar Dave Chinner Committed by Carlos Maiolino
Browse files

xfs: add tracepoints for stale pinned inode state debug 



I needed more insight into how stale inodes were getting stuck on
the AIL after a forced shutdown when running fsstress. These are the
tracepoints I added for that purpose.

Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent d62016b1

fs/xfs/xfs_inode_item.c

+4 −1
Original line number Diff line number Diff line
@@ -758,11 +758,14 @@ xfs_inode_item_push( 
		 * completed and items removed from the AIL before the next push

		 * attempt.

		 */

		trace_xfs_inode_push_stale(ip, _RET_IP_);

		return XFS_ITEM_PINNED;

	}



	if (xfs_ipincount(ip) > 0 || xfs_buf_ispinned(bp))

	if (xfs_ipincount(ip) > 0 || xfs_buf_ispinned(bp)) {

		trace_xfs_inode_push_pinned(ip, _RET_IP_);

		return XFS_ITEM_PINNED;

	}



	if (xfs_iflags_test(ip, XFS_IFLUSHING))

		return XFS_ITEM_FLUSHING;

fs/xfs/xfs_log_cil.c

+3 −1
Original line number Diff line number Diff line
@@ -793,8 +793,10 @@ xlog_cil_ail_insert( 
		struct xfs_log_item	*lip = lv->lv_item;

		xfs_lsn_t		item_lsn;



		if (aborted)

		if (aborted) {

			trace_xlog_ail_insert_abort(lip);

			set_bit(XFS_LI_ABORTED, &lip->li_flags);

		}



		if (lip->li_ops->flags & XFS_ITEM_RELEASE_WHEN_COMMITTED) {

			lip->li_ops->iop_release(lip);

fs/xfs/xfs_trace.h

+8 −1
Original line number Diff line number Diff line
@@ -1146,6 +1146,7 @@ DECLARE_EVENT_CLASS(xfs_iref_class, 
		__field(xfs_ino_t, ino)

		__field(int, count)

		__field(int, pincount)

		__field(unsigned long, iflags)

		__field(unsigned long, caller_ip)

	),

	TP_fast_assign(
@@ -1153,13 +1154,15 @@ DECLARE_EVENT_CLASS(xfs_iref_class, 
		__entry->ino = ip->i_ino;

		__entry->count = atomic_read(&VFS_I(ip)->i_count);

		__entry->pincount = atomic_read(&ip->i_pincount);

		__entry->iflags = ip->i_flags;

		__entry->caller_ip = caller_ip;

	),

	TP_printk("dev %d:%d ino 0x%llx count %d pincount %d caller %pS",

	TP_printk("dev %d:%d ino 0x%llx count %d pincount %d iflags 0x%lx caller %pS",

		  MAJOR(__entry->dev), MINOR(__entry->dev),

		  __entry->ino,

		  __entry->count,

		  __entry->pincount,

		  __entry->iflags,

		  (char *)__entry->caller_ip)

)
@@ -1249,6 +1252,8 @@ DEFINE_IREF_EVENT(xfs_irele); 
DEFINE_IREF_EVENT(xfs_inode_pin);

DEFINE_IREF_EVENT(xfs_inode_unpin);

DEFINE_IREF_EVENT(xfs_inode_unpin_nowait);

DEFINE_IREF_EVENT(xfs_inode_push_pinned);

DEFINE_IREF_EVENT(xfs_inode_push_stale);



DECLARE_EVENT_CLASS(xfs_namespace_class,

	TP_PROTO(struct xfs_inode *dp, const struct xfs_name *name),
@@ -1653,6 +1658,8 @@ DEFINE_LOG_ITEM_EVENT(xfs_ail_flushing); 
DEFINE_LOG_ITEM_EVENT(xfs_cil_whiteout_mark);

DEFINE_LOG_ITEM_EVENT(xfs_cil_whiteout_skip);

DEFINE_LOG_ITEM_EVENT(xfs_cil_whiteout_unpin);

DEFINE_LOG_ITEM_EVENT(xlog_ail_insert_abort);

DEFINE_LOG_ITEM_EVENT(xfs_trans_free_abort);



DECLARE_EVENT_CLASS(xfs_ail_class,

	TP_PROTO(struct xfs_log_item *lip, xfs_lsn_t old_lsn, xfs_lsn_t new_lsn),

fs/xfs/xfs_trans.c

+3 −1
Original line number Diff line number Diff line
@@ -742,8 +742,10 @@ xfs_trans_free_items( 


	list_for_each_entry_safe(lip, next, &tp->t_items, li_trans) {

		xfs_trans_del_item(lip);

		if (abort)

		if (abort) {

			trace_xfs_trans_free_abort(lip);

			set_bit(XFS_LI_ABORTED, &lip->li_flags);

		}

		if (lip->li_ops->iop_release)

			lip->li_ops->iop_release(lip);

	}