Commit fc702e7d authored by Edward Adam Davis's avatar Edward Adam Davis Committed by Greg Kroah-Hartman
Browse files

vt: move vc_saved_screen to within tty allocated judgment 



Everything starts with the assumption that a tty has been allocated.
Therefore, Move it to within the tty allocation check.

Fixes: 23743ba6 ("vt: add support for smput/rmput escape codes")
Reported-by: default avatar <syzbot+f6cb41c144427dc0796a@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=f6cb41c144427dc0796a


Tested-by: default avatar <syzbot+f6cb41c144427dc0796a@syzkaller.appspotmail.com>
Signed-off-by: default avatarEdward Adam Davis <eadavis@qq.com>
Reviewed-by: default avatarJiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/tencent_CAD45DB31906CF890DBB25AB0DED12205D07@qq.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e8178389

drivers/tty/vt/vt.c

+4 −4
Original line number Diff line number Diff line
@@ -1341,11 +1341,11 @@ struct vc_data *vc_deallocate(unsigned int currcons) 
		vc_uniscr_set(vc, NULL);

		kfree(vc->vc_screenbuf);

		vc_cons[currcons].d = NULL;

	}

		if (vc->vc_saved_screen != NULL) {

			kfree(vc->vc_saved_screen);

			vc->vc_saved_screen = NULL;

		}

	}

	return vc;

}