Commit fca4f233 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI: TAD: Clear unused RT data in acpi_tad_set_real_time() 



Move the clearing of the fields in struct acpi_tad_rt that are not used
on the real time setting side to acpi_tad_set_real_time().

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/8660506.T7Z3S40VBb@rafael.j.wysocki
parent 3329a141

drivers/acpi/acpi_tad.c

+4 −4
Original line number Diff line number Diff line
@@ -96,6 +96,10 @@ static int acpi_tad_set_real_time(struct device *dev, struct acpi_tad_rt *rt) 
	if (acpi_tad_rt_is_invalid(rt))

		return -EINVAL;



	rt->valid = 0;

	rt->msec = 0;

	memset(rt->padding, 0, 3);



	args[0].buffer.pointer = (u8 *)rt;

	args[0].buffer.length = sizeof(*rt);
@@ -233,10 +237,6 @@ static ssize_t time_store(struct device *dev, struct device_attribute *attr, 


	rt.daylight = val;



	rt.valid = 0;

	rt.msec = 0;

	memset(rt.padding, 0, 3);



	ret = acpi_tad_set_real_time(dev, &rt);

	if (ret)

		return ret;