Commit fca5b785 authored by Barak Biber's avatar Barak Biber Committed by Joerg Roedel
Browse files

iommu: Restore lost return in iommu_report_device_fault() 



When iommu_report_device_fault gets called with a partial fault it is
supposed to collect the fault into the group and then return.

Instead the return was accidently deleted which results in trying to
process the fault and an eventual crash.

Deleting the return was a typo, put it back.

Fixes: 3dfa64ae ("iommu: Make iommu_report_device_fault() return void")
Signed-off-by: default avatarBarak Biber <bbiber@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Reviewed-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/0-v1-e7153d9c8cee+1c6-iommu_fault_fix_jgg@nvidia.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 8400291e

drivers/iommu/io-pgfault.c

+1 −0
Original line number Diff line number Diff line
@@ -170,6 +170,7 @@ void iommu_report_device_fault(struct device *dev, struct iopf_fault *evt) 
		report_partial_fault(iopf_param, fault);

		iopf_put_dev_fault_param(iopf_param);

		/* A request that is not the last does not need to be ack'd */

		return;

	}



	/*