Commit fcef1a9d authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915/overlay: Switch to intel_frontbuffer_flip() 



Get rid of intel_frontbuffer_flip_{prepare,complete}() from
the overlay code and just use intel_frontbuffer_flip() instead.

The only difference between these are the light interactions
with the ORIGIN_CS busyness tracking, but since the only user
of this is the overlay/xf86-video-intel/Xv the buffer will
always be filled by the CPU and thus we'll never see any
ORIGIN_CS frontbuffer activity there anyway. Also I don't
think we actually have anything covered by the frontbuffer
tracking that affects the overlay (FBC is on the primary
plane, DRRS isn't currently enabled on the platforms with
overlay, and PSR doesn't exist in the hardware).

Acked-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20251016185408.22735-3-ville.syrjala@linux.intel.com
parent 6d2ccd2f

drivers/gpu/drm/i915/display/intel_overlay.c

+1 −3
Original line number Diff line number Diff line
@@ -307,8 +307,6 @@ static void intel_overlay_flip_prepare(struct intel_overlay *overlay, 
		intel_frontbuffer_put(overlay->frontbuffer);

	overlay->frontbuffer = frontbuffer;



	intel_frontbuffer_flip_prepare(display, INTEL_FRONTBUFFER_OVERLAY(pipe));



	overlay->old_vma = overlay->vma;

	if (vma)

		overlay->vma = i915_vma_get(vma);
@@ -365,7 +363,7 @@ static void intel_overlay_release_old_vma(struct intel_overlay *overlay) 
	if (drm_WARN_ON(display->drm, !vma))

		return;



	intel_frontbuffer_flip_complete(display, INTEL_FRONTBUFFER_OVERLAY(overlay->crtc->pipe));

	intel_frontbuffer_flip(display, INTEL_FRONTBUFFER_OVERLAY(overlay->crtc->pipe));



	i915_vma_unpin(vma);

	i915_vma_put(vma);