Commit fceff12e authored by Krzysztof Niemiec's avatar Krzysztof Niemiec Committed by Andi Shyti
Browse files

drm/i915/gt: Empty uabi engines list during intel_engines_release() 



While the uabi_engines_llist is populated in intel_engines_init() during
driver load, the corresponding function intel_engines_release() does not
correctly get rid of it. This can lead to a UAF if, after failed
initialization (for example when gt is set wedged on init), we try to
access the engines.

Suggested-by: default avatarChris Wilson <chris.p.wilson@linux.intel.com>
Signed-off-by: default avatarKrzysztof Niemiec <krzysztof.niemiec@intel.com>
Reviewed-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240801154047.115176-2-krzysztof.niemiec@intel.com
parent 843f10ce

drivers/gpu/drm/i915/gt/intel_engine_cs.c

+2 −0
Original line number Diff line number Diff line
@@ -693,6 +693,8 @@ void intel_engines_release(struct intel_gt *gt) 


		memset(&engine->reset, 0, sizeof(engine->reset));

	}



	llist_del_all(&gt->i915->uabi_engines_llist);

}



void intel_engine_free_request_pool(struct intel_engine_cs *engine)