Commit fd579a2e authored by David Howells's avatar David Howells Committed by Paolo Abeni
Browse files

rxrpc: Fix return from none_validate_challenge() 



Fix the return value of none_validate_challenge() to be explicitly true
(which indicates the source packet should simply be discarded) rather than
implicitly true (because rxrpc_abort_conn() always returns -EPROTO which
gets converted to true).

Note that this change doesn't change the behaviour of the code (which is
correct by accident) and, in any case, we *shouldn't* get a CHALLENGE
packet to an rxnull connection (ie. no security).

Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lists.infradead.org/pipermail/linux-afs/2025-April/009738.html


Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: Jakub Kicinski <kuba@kernel.org>
cc: "David S. Miller" <davem@davemloft.net>
cc: Eric Dumazet <edumazet@google.com>
cc: Paolo Abeni <pabeni@redhat.com>
cc: Simon Horman <horms@kernel.org>
cc: linux-afs@lists.infradead.org
cc: netdev@vger.kernel.org
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/10720.1748358103@warthog.procyon.org.uk


Fixes: 5800b1cf ("rxrpc: Allow CHALLENGEs to the passed to the app for a RESPONSE")
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent f41a94aa

net/rxrpc/insecure.c

+3 −2
Original line number Diff line number Diff line
@@ -45,8 +45,9 @@ static void none_free_call_crypto(struct rxrpc_call *call) 
static bool none_validate_challenge(struct rxrpc_connection *conn,

				    struct sk_buff *skb)

{

	return rxrpc_abort_conn(conn, skb, RX_PROTOCOL_ERROR, -EPROTO,

	rxrpc_abort_conn(conn, skb, RX_PROTOCOL_ERROR, -EPROTO,

			 rxrpc_eproto_rxnull_challenge);

	return true;

}



static int none_sendmsg_respond_to_challenge(struct sk_buff *challenge,