Commit fd5bed79 authored by Felix Gu's avatar Felix Gu Committed by Linus Walleij
Browse files

pinctrl: cirrus: cs42l43: Fix double-put in cs42l43_pin_probe() 



devm_add_action_or_reset() already invokes the action on failure,
so the explicit put causes a double-put.

Fixes: 9b07cdf8 ("pinctrl: cirrus: Fix fwnode leak in cs42l43_pin_probe()")
Signed-off-by: default avatarFelix Gu <ustc.gu@gmail.com>
Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: default avatarLinus Walleij <linusw@kernel.org>
parent a2539b92

drivers/pinctrl/cirrus/pinctrl-cs42l43.c

+2 −3
Original line number Diff line number Diff line
@@ -574,10 +574,9 @@ static int cs42l43_pin_probe(struct platform_device *pdev) 
		if (child) {

			ret = devm_add_action_or_reset(&pdev->dev,

				cs42l43_fwnode_put, child);

			if (ret) {

				fwnode_handle_put(child);

			if (ret)

				return ret;

			}



			if (!child->dev)

				child->dev = priv->dev;

			fwnode = child;