Commit fd78ec3f authored by Kalesh AP's avatar Kalesh AP Committed by David S. Miller
Browse files

bnxt_en: Fix invoking hwmon_notify_event 



FW sends the async event to the driver when the device temperature goes
above or below the threshold values.  Only notify hwmon if the
temperature is increasing to the next alert level, not when it is
decreasing.

Cc: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarKashyap Desai <kashyap.desai@broadcom.com>
Reviewed-by: default avatarSomnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 55862094

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+11 −5
Original line number Diff line number Diff line
@@ -2166,6 +2166,7 @@ static bool bnxt_event_error_report(struct bnxt *bp, u32 data1, u32 data2) 
	case ASYNC_EVENT_CMPL_ERROR_REPORT_BASE_EVENT_DATA1_ERROR_TYPE_THERMAL_THRESHOLD: {

		u32 type = EVENT_DATA1_THERMAL_THRESHOLD_TYPE(data1);

		char *threshold_type;

		bool notify = false;

		char *dir_str;



		switch (type) {
@@ -2185,19 +2186,24 @@ static bool bnxt_event_error_report(struct bnxt *bp, u32 data1, u32 data2) 
			netdev_err(bp->dev, "Unknown Thermal threshold type event\n");

			return false;

		}

		if (EVENT_DATA1_THERMAL_THRESHOLD_DIR_INCREASING(data1))

		if (EVENT_DATA1_THERMAL_THRESHOLD_DIR_INCREASING(data1)) {

			dir_str = "above";

		else

			notify = true;

		} else {

			dir_str = "below";

		}

		netdev_warn(bp->dev, "Chip temperature has gone %s the %s thermal threshold!\n",

			    dir_str, threshold_type);

		netdev_warn(bp->dev, "Temperature (In Celsius), Current: %lu, threshold: %lu\n",

			    BNXT_EVENT_THERMAL_CURRENT_TEMP(data2),

			    BNXT_EVENT_THERMAL_THRESHOLD_TEMP(data2));

		if (notify) {

			bp->thermal_threshold_type = type;

			set_bit(BNXT_THERMAL_THRESHOLD_SP_EVENT, &bp->sp_event);

			return true;

		}

		return false;

	}

	default:

		netdev_err(bp->dev, "FW reported unknown error type %u\n",

			   err_type);