Commit fdd3d14c authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Vinod Koul
Browse files

soundwire: debugfs: simplify with cleanup.h 



Allocate the memory with scoped/cleanup.h to reduce error handling and
make the code a bit simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240703-soundwire-cleanup-h-v1-9-24fa0dbb948f@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent b72d4af9

drivers/soundwire/debugfs.c

+2 −5
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

// Copyright(c) 2017-2019 Intel Corporation.



#include <linux/cleanup.h>

#include <linux/device.h>

#include <linux/debugfs.h>

#include <linux/firmware.h>
@@ -49,18 +50,16 @@ static ssize_t sdw_sprintf(struct sdw_slave *slave, 
static int sdw_slave_reg_show(struct seq_file *s_file, void *data)

{

	struct sdw_slave *slave = s_file->private;

	char *buf;

	ssize_t ret;

	int i, j;



	buf = kzalloc(RD_BUF, GFP_KERNEL);

	char *buf __free(kfree) = kzalloc(RD_BUF, GFP_KERNEL);

	if (!buf)

		return -ENOMEM;



	ret = pm_runtime_get_sync(&slave->dev);

	if (ret < 0 && ret != -EACCES) {

		pm_runtime_put_noidle(&slave->dev);

		kfree(buf);

		return ret;

	}
@@ -132,8 +131,6 @@ static int sdw_slave_reg_show(struct seq_file *s_file, void *data) 
	pm_runtime_mark_last_busy(&slave->dev);

	pm_runtime_put(&slave->dev);



	kfree(buf);



	return 0;

}

DEFINE_SHOW_ATTRIBUTE(sdw_slave_reg);