Commit fddf72ed authored by Marc Zyngier's avatar Marc Zyngier Committed by Bjorn Helgaas
Browse files

PCI: xgene: Drop XGENE_PCIE_IP_VER_UNKN 



XGENE_PCIE_IP_VER_UNKN is only refered to when probing for the
original XGene PCIe implementation, and get immediately overridden
if the device has the "apm,xgene-pcie" compatible string.

Given that the only way to get there is by finding this very string in
the DT, it is obvious that we will always overwrite the version with
XGENE_PCIE_IP_VER_1.

Drop the whole thing.

Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20250708173404.1278635-5-maz@kernel.org
parent e3ac25cc

drivers/pci/controller/pci-xgene.c

+1 −5
Original line number Diff line number Diff line
@@ -54,7 +54,6 @@ 
#define XGENE_V1_PCI_EXP_CAP		0x40



/* PCIe IP version */

#define XGENE_PCIE_IP_VER_UNKN		0

#define XGENE_PCIE_IP_VER_1		1

#define XGENE_PCIE_IP_VER_2		2
@@ -630,9 +629,6 @@ static int xgene_pcie_probe(struct platform_device *pdev) 


	port->node = of_node_get(dn);

	port->dev = dev;



	port->version = XGENE_PCIE_IP_VER_UNKN;

	if (of_device_is_compatible(port->node, "apm,xgene-pcie"))

	port->version = XGENE_PCIE_IP_VER_1;



	ret = xgene_pcie_map_reg(port, pdev);