Commit fddffe84 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Hans Verkuil
Browse files

media: s5p-mfc: Fix an error handling path s5p_mfc_open() 



A mfc_debug_enter() is not balanced by a corresponding mfc_debug_leave().
Add the missing call.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
parent 5c546082

drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c

+5 −2
Original line number Diff line number Diff line
@@ -774,8 +774,10 @@ static int s5p_mfc_open(struct file *file) 
	int ret = 0;



	mfc_debug_enter();

	if (mutex_lock_interruptible(&dev->mfc_mutex))

		return -ERESTARTSYS;

	if (mutex_lock_interruptible(&dev->mfc_mutex)) {

		ret = -ERESTARTSYS;

		goto err_enter;

	}

	dev->num_inst++;	/* It is guarded by mfc_mutex in vfd */

	/* Allocate memory for context */

	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
@@ -946,6 +948,7 @@ static int s5p_mfc_open(struct file *file) 
err_alloc:

	dev->num_inst--;

	mutex_unlock(&dev->mfc_mutex);

err_enter:

	mfc_debug_leave();

	return ret;

}