Unverified Commit fdee1b09 authored by Mario Limonciello's avatar Mario Limonciello Committed by Ilpo Järvinen
Browse files

platform/x86: hp-bioscfg: Fix kobject warnings for empty attribute names 



The hp-bioscfg driver attempts to register kobjects with empty names when
the HP BIOS returns attributes with empty name strings. This causes
multiple kernel warnings:

  kobject: (00000000135fb5e6): attempted to be registered with empty name!
  WARNING: CPU: 14 PID: 3336 at lib/kobject.c:219 kobject_add_internal+0x2eb/0x310

Add validation in hp_init_bios_buffer_attribute() to check if the
attribute name is empty after parsing it from the WMI buffer. If empty,
log a debug message and skip registration of that attribute, allowing the
module to continue processing other valid attributes.

Cc: stable@vger.kernel.org
Fixes: a34fc329 ("platform/x86: hp-bioscfg: bioscfg")
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://patch.msgid.link/20260115203725.828434-2-mario.limonciello@amd.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent f7fffd2e

drivers/platform/x86/hp/hp-bioscfg/bioscfg.c

+8 −0
Original line number Diff line number Diff line
@@ -10,6 +10,8 @@ 
#include <linux/fs.h>

#include <linux/module.h>

#include <linux/kernel.h>

#include <linux/printk.h>

#include <linux/string.h>

#include <linux/wmi.h>

#include "bioscfg.h"

#include "../../firmware_attributes_class.h"
@@ -781,6 +783,12 @@ static int hp_init_bios_buffer_attribute(enum hp_wmi_data_type attr_type, 
	if (ret < 0)

		goto buff_attr_exit;



	if (strlen(str) == 0) {

		pr_debug("Ignoring attribute with empty name\n");

		ret = 0;

		goto buff_attr_exit;

	}



	if (attr_type == HPWMI_PASSWORD_TYPE ||

	    attr_type == HPWMI_SECURE_PLATFORM_TYPE)

		temp_kset = bioscfg_drv.authentication_dir_kset;