Commit fdf5703b authored by Darrick J. Wong's avatar Darrick J. Wong
Browse files

xfs: constify the xfs_inode predicates 



Change the xfs_inode predicates to take a const struct xfs_inode pointer
because they do not change the inode.

Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
parent 8d939f4b

fs/xfs/xfs_inode.c

+1 −1
Original line number Diff line number Diff line
@@ -3040,7 +3040,7 @@ xfs_inode_alloc_unitsize( 
/* Should we always be using copy on write for file writes? */

bool

xfs_is_always_cow_inode(

	struct xfs_inode	*ip)

	const struct xfs_inode	*ip)

{

	return ip->i_mount->m_always_cow && xfs_has_reflink(ip->i_mount);

}

fs/xfs/xfs_inode.h

+10 −10
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ static inline bool xfs_inode_on_unlinked_list(const struct xfs_inode *ip) 
	return ip->i_prev_unlinked != 0;

}



static inline bool xfs_inode_has_attr_fork(struct xfs_inode *ip)

static inline bool xfs_inode_has_attr_fork(const struct xfs_inode *ip)

{

	return ip->i_forkoff > 0;

}
@@ -271,7 +271,7 @@ xfs_iflags_test_and_set(xfs_inode_t *ip, unsigned long flags) 
	return ret;

}



static inline bool xfs_is_reflink_inode(struct xfs_inode *ip)

static inline bool xfs_is_reflink_inode(const struct xfs_inode *ip)

{

	return ip->i_diflags2 & XFS_DIFLAG2_REFLINK;

}
@@ -285,9 +285,9 @@ static inline bool xfs_is_metadata_inode(const struct xfs_inode *ip) 
	       xfs_is_quota_inode(&mp->m_sb, ip->i_ino);

}



bool xfs_is_always_cow_inode(struct xfs_inode *ip);

bool xfs_is_always_cow_inode(const struct xfs_inode *ip);



static inline bool xfs_is_cow_inode(struct xfs_inode *ip)

static inline bool xfs_is_cow_inode(const struct xfs_inode *ip)

{

	return xfs_is_reflink_inode(ip) || xfs_is_always_cow_inode(ip);

}
@@ -301,17 +301,17 @@ static inline bool xfs_inode_has_filedata(const struct xfs_inode *ip) 
 * Check if an inode has any data in the COW fork.  This might be often false

 * even for inodes with the reflink flag when there is no pending COW operation.

 */

static inline bool xfs_inode_has_cow_data(struct xfs_inode *ip)

static inline bool xfs_inode_has_cow_data(const struct xfs_inode *ip)

{

	return ip->i_cowfp && ip->i_cowfp->if_bytes;

}



static inline bool xfs_inode_has_bigtime(struct xfs_inode *ip)

static inline bool xfs_inode_has_bigtime(const struct xfs_inode *ip)

{

	return ip->i_diflags2 & XFS_DIFLAG2_BIGTIME;

}



static inline bool xfs_inode_has_large_extent_counts(struct xfs_inode *ip)

static inline bool xfs_inode_has_large_extent_counts(const struct xfs_inode *ip)

{

	return ip->i_diflags2 & XFS_DIFLAG2_NREXT64;

}
@@ -320,7 +320,7 @@ static inline bool xfs_inode_has_large_extent_counts(struct xfs_inode *ip) 
 * Decide if this file is a realtime file whose data allocation unit is larger

 * than a single filesystem block.

 */

static inline bool xfs_inode_has_bigrtalloc(struct xfs_inode *ip)

static inline bool xfs_inode_has_bigrtalloc(const struct xfs_inode *ip)

{

	return XFS_IS_REALTIME_INODE(ip) && ip->i_mount->m_sb.sb_rextsize > 1;

}
@@ -625,9 +625,9 @@ void xfs_sort_inodes(struct xfs_inode **i_tab, unsigned int num_inodes); 


static inline bool

xfs_inode_unlinked_incomplete(

	struct xfs_inode	*ip)

	const struct xfs_inode	*ip)

{

	return VFS_I(ip)->i_nlink == 0 && !xfs_inode_on_unlinked_list(ip);

	return VFS_IC(ip)->i_nlink == 0 && !xfs_inode_on_unlinked_list(ip);

}

int xfs_inode_reload_unlinked_bucket(struct xfs_trans *tp, struct xfs_inode *ip);

int xfs_inode_reload_unlinked(struct xfs_inode *ip);