Commit fe24d5bc authored by Brett Creeley's avatar Brett Creeley Committed by Alex Williamson
Browse files

vfio/pds: Fix missing detach_ioas op 



When CONFIG_IOMMUFD is enabled and a device is bound to the pds_vfio_pci
driver, the following WARN_ON() trace is seen and probe fails:

WARNING: CPU: 0 PID: 5040 at drivers/vfio/vfio_main.c:317 __vfio_register_dev+0x130/0x140 [vfio]
<...>
pds_vfio_pci 0000:08:00.1: probe with driver pds_vfio_pci failed with error -22

This is because the driver's vfio_device_ops.detach_ioas isn't set.

Fix this by using the generic vfio_iommufd_physical_detach_ioas
function.

Fixes: 38fe3975 ("vfio/pds: Initial support for pds VFIO driver")
Signed-off-by: default avatarBrett Creeley <brett.creeley@amd.com>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Link: https://lore.kernel.org/r/20250702163744.69767-1-brett.creeley@amd.com


Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent 982ddd59

drivers/vfio/pci/pds/vfio_dev.c

+1 −0
Original line number Diff line number Diff line
@@ -204,6 +204,7 @@ static const struct vfio_device_ops pds_vfio_ops = { 
	.bind_iommufd = vfio_iommufd_physical_bind,

	.unbind_iommufd = vfio_iommufd_physical_unbind,

	.attach_ioas = vfio_iommufd_physical_attach_ioas,

	.detach_ioas = vfio_iommufd_physical_detach_ioas,

};



const struct vfio_device_ops *pds_vfio_ops_info(void)