Commit fe2a3493 authored by Jacopo Mondi's avatar Jacopo Mondi Committed by Hans Verkuil
Browse files

media: vsp1: vsp1_dl: Count display lists 



To detect leaks of display lists, store in the display list manager the
number of allocated display lists when the manager is created and verify
that when the display manager is reset the same number of lists is
available in the free list.

Signed-off-by: default avatarJacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Link: https://lore.kernel.org/r/20250616-vsp1_dl_list_count-v2-2-7d3f43fb1306@ideasonboard.com


Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
parent 30e77ed1

drivers/media/platform/renesas/vsp1/vsp1_dl.c

+9 −0
Original line number Diff line number Diff line
@@ -215,6 +215,7 @@ struct vsp1_dl_list { 
 * @pending: list waiting to be queued to the hardware

 * @pool: body pool for the display list bodies

 * @cmdpool: commands pool for extended display list

 * @list_count: number of allocated display lists

 */

struct vsp1_dl_manager {

	unsigned int index;
@@ -229,6 +230,8 @@ struct vsp1_dl_manager { 


	struct vsp1_dl_body_pool *pool;

	struct vsp1_dl_cmd_pool *cmdpool;



	size_t list_count;

};



/* -----------------------------------------------------------------------------
@@ -1078,6 +1081,7 @@ void vsp1_dlm_setup(struct vsp1_device *vsp1) 
void vsp1_dlm_reset(struct vsp1_dl_manager *dlm)

{

	unsigned long flags;

	size_t list_count;



	spin_lock_irqsave(&dlm->lock, flags);
@@ -1085,8 +1089,11 @@ void vsp1_dlm_reset(struct vsp1_dl_manager *dlm) 
	__vsp1_dl_list_put(dlm->queued);

	__vsp1_dl_list_put(dlm->pending);



	list_count = list_count_nodes(&dlm->free);

	spin_unlock_irqrestore(&dlm->lock, flags);



	WARN_ON_ONCE(list_count != dlm->list_count);



	dlm->active = NULL;

	dlm->queued = NULL;

	dlm->pending = NULL;
@@ -1156,6 +1163,8 @@ struct vsp1_dl_manager *vsp1_dlm_create(struct vsp1_device *vsp1, 
		list_add_tail(&dl->list, &dlm->free);

	}



	dlm->list_count = prealloc;



	if (vsp1_feature(vsp1, VSP1_HAS_EXT_DL)) {

		dlm->cmdpool = vsp1_dl_cmd_pool_create(vsp1,

					VSP1_EXTCMD_AUTOFLD, prealloc);