Commit fe4b4188 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Steve French
Browse files

ksmbd: Remove unused functions 



ksmbd_rpc_rap() was added in 2021 as part of
commit 0626e664 ("cifsd: add server handler for central processing and
tranport layers")

ksmbd_vfs_posix_lock_wait_timeout() was added in 2021 as part of
commit f4415848 ("cifsd: add file operations")

both have remained unused.

Remove them.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Acked-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 5bc55a33

fs/smb/server/transport_ipc.c

+0 −25
Original line number Diff line number Diff line
@@ -871,31 +871,6 @@ struct ksmbd_rpc_command *ksmbd_rpc_ioctl(struct ksmbd_session *sess, int handle 
	return resp;

}



struct ksmbd_rpc_command *ksmbd_rpc_rap(struct ksmbd_session *sess, void *payload,

					size_t payload_sz)

{

	struct ksmbd_ipc_msg *msg;

	struct ksmbd_rpc_command *req;

	struct ksmbd_rpc_command *resp;



	msg = ipc_msg_alloc(sizeof(struct ksmbd_rpc_command) + payload_sz + 1);

	if (!msg)

		return NULL;



	msg->type = KSMBD_EVENT_RPC_REQUEST;

	req = (struct ksmbd_rpc_command *)msg->payload;

	req->handle = ksmbd_acquire_id(&ipc_ida);

	req->flags = rpc_context_flags(sess);

	req->flags |= KSMBD_RPC_RAP_METHOD;

	req->payload_sz = payload_sz;

	memcpy(req->payload, payload, payload_sz);



	resp = ipc_msg_send_request(msg, req->handle);

	ipc_msg_handle_free(req->handle);

	ipc_msg_free(msg);

	return resp;

}



static int __ipc_heartbeat(void)

{

	unsigned long delta;

fs/smb/server/transport_ipc.h

+0 −2
Original line number Diff line number Diff line
@@ -41,8 +41,6 @@ struct ksmbd_rpc_command *ksmbd_rpc_write(struct ksmbd_session *sess, int handle 
struct ksmbd_rpc_command *ksmbd_rpc_read(struct ksmbd_session *sess, int handle);

struct ksmbd_rpc_command *ksmbd_rpc_ioctl(struct ksmbd_session *sess, int handle,

					  void *payload, size_t payload_sz);

struct ksmbd_rpc_command *ksmbd_rpc_rap(struct ksmbd_session *sess, void *payload,

					size_t payload_sz);

void ksmbd_ipc_release(void);

void ksmbd_ipc_soft_reset(void);

int ksmbd_ipc_init(void);

fs/smb/server/vfs.c

+0 −7
Original line number Diff line number Diff line
@@ -1856,13 +1856,6 @@ void ksmbd_vfs_posix_lock_wait(struct file_lock *flock) 
	wait_event(flock->c.flc_wait, !flock->c.flc_blocker);

}



int ksmbd_vfs_posix_lock_wait_timeout(struct file_lock *flock, long timeout)

{

	return wait_event_interruptible_timeout(flock->c.flc_wait,

						!flock->c.flc_blocker,

						timeout);

}



void ksmbd_vfs_posix_lock_unblock(struct file_lock *flock)

{

	locks_delete_block(flock);

fs/smb/server/vfs.h

+0 −1
Original line number Diff line number Diff line
@@ -140,7 +140,6 @@ int ksmbd_vfs_fill_dentry_attrs(struct ksmbd_work *work, 
				struct dentry *dentry,

				struct ksmbd_kstat *ksmbd_kstat);

void ksmbd_vfs_posix_lock_wait(struct file_lock *flock);

int ksmbd_vfs_posix_lock_wait_timeout(struct file_lock *flock, long timeout);

void ksmbd_vfs_posix_lock_unblock(struct file_lock *flock);

int ksmbd_vfs_remove_acl_xattrs(struct mnt_idmap *idmap,

				const struct path *path);