Commit fe4cd7ed authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: zoned: fix missing RCU locking in error message when loading zone info 



At btrfs_load_zone_info() we have an error path that is dereferencing
the name of a device which is a RCU string but we are not holding a RCU
read lock, which is incorrect.

Fix this by using btrfs_err_in_rcu() instead of btrfs_err().

The problem is there since commit 08e11a3d ("btrfs: zoned: load zone's
allocation offset"), back then at btrfs_load_block_group_zone_info() but
then later on that code was factored out into the helper
btrfs_load_zone_info() by commit 09a46725 ("btrfs: zoned: factor out
per-zone logic from btrfs_load_block_group_zone_info").

Fixes: 08e11a3d ("btrfs: zoned: load zone's allocation offset")
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarNaohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 6ef8fbce

fs/btrfs/zoned.c

+1 −1
Original line number Diff line number Diff line
@@ -1340,7 +1340,7 @@ static int btrfs_load_zone_info(struct btrfs_fs_info *fs_info, int zone_idx, 
	switch (zone.cond) {

	case BLK_ZONE_COND_OFFLINE:

	case BLK_ZONE_COND_READONLY:

		btrfs_err(fs_info,

		btrfs_err_in_rcu(fs_info,

		"zoned: offline/readonly zone %llu on device %s (devid %llu)",

			  (info->physical >> device->zone_info->zone_size_shift),

			  rcu_str_deref(device->name), device->devid);