Commit fe5669e3 authored by Ioana Ciornei's avatar Ioana Ciornei Committed by Thomas Gleixner
Browse files

irqchip/ls-extirq: Fix devm_of_iomap() error check 



The devm_of_iomap() function returns an ERR_PTR() encoded error code on
failure. Replace the incorrect check against NULL with IS_ERR().

Fixes: 05cd6548 ("irqchip/ls-extirq: Convert to a platform driver to make it work again")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarIoana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: default avatarThomas Gleixner <tglx@kernel.org>
Reviewed-by: default avatarHerve Codina <herve.codina@bootlin.com>
Link: https://patch.msgid.link/20260224113610.1129022-3-ioana.ciornei@nxp.com
Closes: https://lore.kernel.org/all/aYXvfbfT6w0TMsXS@stanley.mountain/
parent e08f2adc

drivers/irqchip/irq-ls-extirq.c

+4 −2
Original line number Diff line number Diff line
@@ -190,8 +190,10 @@ static int ls_extirq_probe(struct platform_device *pdev) 
		return dev_err_probe(dev, -ENOMEM, "Failed to allocate memory\n");



	priv->intpcr = devm_of_iomap(dev, node, 0, NULL);

	if (!priv->intpcr)

		return dev_err_probe(dev, -ENOMEM, "Cannot ioremap OF node %pOF\n", node);

	if (IS_ERR(priv->intpcr)) {

		return dev_err_probe(dev, PTR_ERR(priv->intpcr),

				     "Cannot ioremap OF node %pOF\n", node);

	}



	ret = ls_extirq_parse_map(priv, node);

	if (ret)