Commit fe62415c authored by William Kucharski's avatar William Kucharski Committed by Andrew Morton
Browse files

mm: remove reference to destructor in comment in calculate_sizes() 

The commit that removed support for destructors from kmem_cache_alloc()
never removed the comment regarding destructors in the explanation of the
possible relocation of the free pointer in calculate_sizes().

Link: https://lkml.kernel.org/r/20251021110004.2209008-1-william.kucharski@oracle.com


Fixes: 20c2df83 ("mm: Remove slab destructors from kmem_cache_create().")
Signed-off-by: default avatarWilliam Kucharski <william.kucharski@oracle.com>
Acked-by: default avatarRoman Gushchin <roman.gushchin@linux.dev>
Reviewed-by: default avatarChristoph Lameter (Ampere) <cl@gentwo.org>
Acked-by: default avatarSeongJae Park <sj@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Harry Yoo <harry.yoo@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 2da6fe91

mm/slub.c

+5 −5
Original line number Diff line number Diff line
@@ -7901,11 +7901,11 @@ static int calculate_sizes(struct kmem_cache_args *args, struct kmem_cache *s) 
		 * permitted to overwrite the first word of the object on

		 * kmem_cache_free.

		 *

		 * This is the case if we do RCU, have a constructor or

		 * destructor, are poisoning the objects, or are

		 * redzoning an object smaller than sizeof(void *) or are

		 * redzoning an object with slub_debug_orig_size() enabled,

		 * in which case the right redzone may be extended.

		 * This is the case if we do RCU, have a constructor, are

		 * poisoning the objects, or are redzoning an object smaller

		 * than sizeof(void *) or are redzoning an object with

		 * slub_debug_orig_size() enabled, in which case the right

		 * redzone may be extended.

		 *

		 * The assumption that s->offset >= s->inuse means free

		 * pointer is outside of the object is used in the