Unverified Commit fe6859aa authored by Mark Pearson's avatar Mark Pearson Committed by Ilpo Järvinen
Browse files

platform/x86: thinklmi: improved DMI handling 



Fix issues reported by kernel test robot.
 - Require DMI for think-lmi.
 - Check return from getting serial string

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506062319.F0IpDxF6-lkp@intel.com/


Signed-off-by: default avatarMark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250610192830.1731454-1-mpearson-lenovo@squebb.ca


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 097cd6d6

drivers/platform/x86/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -659,6 +659,7 @@ config THINKPAD_ACPI_HOTKEY_POLL 
config THINKPAD_LMI

	tristate "Lenovo WMI-based systems management driver"

	depends on ACPI_WMI

	depends on DMI

	select FW_ATTR_CLASS

	help

	  This driver allows changing BIOS settings on Lenovo machines whose

drivers/platform/x86/think-lmi.c

+5 −3
Original line number Diff line number Diff line
@@ -772,6 +772,7 @@ static ssize_t certificate_store(struct kobject *kobj, 
	struct tlmi_pwd_setting *setting = to_tlmi_pwd_setting(kobj);

	enum cert_install_mode install_mode = TLMI_CERT_INSTALL;

	char *auth_str, *new_cert;

	const char *serial;

	char *signature;

	char *guid;

	int ret;
@@ -789,9 +790,10 @@ static ssize_t certificate_store(struct kobject *kobj, 
			return -EACCES;



		/* Format: 'serial#, signature' */

		auth_str = cert_command(setting,

					dmi_get_system_info(DMI_PRODUCT_SERIAL),

					setting->signature);

		serial = dmi_get_system_info(DMI_PRODUCT_SERIAL);

		if (!serial)

			return -ENODEV;

		auth_str = cert_command(setting, serial, setting->signature);

		if (!auth_str)

			return -ENOMEM;