Commit fe85a39d authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Lee Jones
Browse files

backlight: mp3309c: Initialize backlight properties without memset 



Assigning values to a struct using a compound literal (since C99) also
guarantees that all unspecified struct members are empty-initialized, so
it properly replaces the memset to zero.

The code looks a bit nicer and more idiomatic (though that might be
subjective?). The resulting binary is a bit smaller. On ARCH=arm with
an allnoconfig + minimal changes to enable the mp3309c driver the
difference is 12 bytes.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@baylibre.com>
Tested-by: default avatarFlavio Suligoi <f.suligoi@asem.it>
Reviewed-by: default avatarDaniel Thompson (RISCstar) <danielt@kernel.org>
Link: https://lore.kernel.org/r/14514a1b0d3df6438aa10bb74f1c4fc2367d9987.1751361465.git.u.kleine-koenig@baylibre.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 2720c87b

drivers/video/backlight/mp3309c.c

+7 −6
Original line number Diff line number Diff line
@@ -352,12 +352,13 @@ static int mp3309c_probe(struct i2c_client *client) 
	chip->pdata = pdata;



	/* Backlight properties */

	memset(&props, 0, sizeof(struct backlight_properties));

	props.brightness = pdata->default_brightness;

	props.max_brightness = pdata->max_brightness;

	props.scale = BACKLIGHT_SCALE_LINEAR;

	props.type = BACKLIGHT_RAW;

	props.power = BACKLIGHT_POWER_ON;

	props = (typeof(props)){

		.brightness = pdata->default_brightness,

		.max_brightness = pdata->max_brightness,

		.scale = BACKLIGHT_SCALE_LINEAR,

		.type = BACKLIGHT_RAW,

		.power = BACKLIGHT_POWER_ON,

	};

	chip->bl = devm_backlight_device_register(dev, "mp3309c", dev, chip,

						  &mp3309c_bl_ops, &props);

	if (IS_ERR(chip->bl))