Commit fe8db0bb authored by Abhishek Pandit-Subedi's avatar Abhishek Pandit-Subedi Committed by Greg Kroah-Hartman
Browse files

usb: typec: Update sysfs when setting ops 



When adding altmode ops, update the sysfs group so that visibility is
also recalculated.

Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarBenson Leung <bleung@chromium.org>
Signed-off-by: default avatarAbhishek Pandit-Subedi <abhishekpandit@chromium.org>
Signed-off-by: default avatarJameson Thies <jthies@google.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240510201244.2968152-3-jthies@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 99516f76

drivers/usb/typec/altmodes/displayport.c

+1 −1
Original line number Diff line number Diff line
@@ -746,7 +746,7 @@ int dp_altmode_probe(struct typec_altmode *alt) 
	dp->alt = alt;



	alt->desc = "DisplayPort";

	alt->ops = &dp_altmode_ops;

	typec_altmode_set_ops(alt, &dp_altmode_ops);



	if (plug) {

		plug->desc = "Displayport";

drivers/usb/typec/class.c

+17 −1
Original line number Diff line number Diff line
@@ -467,6 +467,22 @@ static const struct attribute_group *typec_altmode_groups[] = { 
	NULL

};



/**

 * typec_altmode_set_ops - Set ops for altmode

 * @adev: Handle to the alternate mode

 * @ops: Ops for the alternate mode

 *

 * After setting ops, attribute visiblity needs to be refreshed if the alternate

 * mode can be activated.

 */

void typec_altmode_set_ops(struct typec_altmode *adev,

			   const struct typec_altmode_ops *ops)

{

	adev->ops = ops;

	sysfs_update_group(&adev->dev.kobj, &typec_altmode_group);

}

EXPORT_SYMBOL_GPL(typec_altmode_set_ops);



static int altmode_id_get(struct device *dev)

{

	struct ida *ids;
@@ -2317,7 +2333,7 @@ void typec_port_register_altmodes(struct typec_port *port, 
			continue;

		}



		alt->ops = ops;

		typec_altmode_set_ops(alt, ops);

		typec_altmode_set_drvdata(alt, drvdata);

		altmodes[index] = alt;

		index++;

drivers/usb/typec/ucsi/displayport.c

+1 −1
Original line number Diff line number Diff line
@@ -333,7 +333,7 @@ struct typec_altmode *ucsi_register_displayport(struct ucsi_connector *con, 
	dp->con = con;

	dp->alt = alt;



	alt->ops = &ucsi_displayport_ops;

	typec_altmode_set_ops(alt, &ucsi_displayport_ops);

	typec_altmode_set_drvdata(alt, dp);



	return alt;

include/linux/usb/typec.h

+3 −0
Original line number Diff line number Diff line
@@ -167,6 +167,9 @@ struct typec_port *typec_altmode2port(struct typec_altmode *alt); 


void typec_altmode_update_active(struct typec_altmode *alt, bool active);



void typec_altmode_set_ops(struct typec_altmode *alt,

			   const struct typec_altmode_ops *ops);



enum typec_plug_index {

	TYPEC_PLUG_SOP_P,

	TYPEC_PLUG_SOP_PP,