Commit feac19aa authored by David Matlack's avatar David Matlack Committed by Sean Christopherson
Browse files

KVM: x86/mmu: Remove function comments above clear_dirty_{gfn_range,pt_masked}() 



Drop the comments above clear_dirty_gfn_range() and
clear_dirty_pt_masked(), since each is word-for-word identical to the
comment above their parent function.

Leave the comment on the parent functions since they are APIs called by
the KVM/x86 MMU.

No functional change intended.

Signed-off-by: default avatarDavid Matlack <dmatlack@google.com>
Link: https://lore.kernel.org/r/20240315230541.1635322-3-dmatlack@google.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent 2673dfb5

arch/x86/kvm/mmu/tdp_mmu.c

+0 −14
Original line number Diff line number Diff line
@@ -1558,13 +1558,6 @@ static bool tdp_mmu_need_write_protect(struct kvm_mmu_page *sp) 
	return kvm_mmu_page_ad_need_write_protect(sp) || !kvm_ad_enabled();

}



/*

 * Clear the dirty status of all the SPTEs mapping GFNs in the memslot. If

 * AD bits are enabled, this will involve clearing the dirty bit on each SPTE.

 * If AD bits are not enabled, this will require clearing the writable bit on

 * each SPTE. Returns true if an SPTE has been changed and the TLBs need to

 * be flushed.

 */

static bool clear_dirty_gfn_range(struct kvm *kvm, struct kvm_mmu_page *root,

			   gfn_t start, gfn_t end)

{
@@ -1621,13 +1614,6 @@ bool kvm_tdp_mmu_clear_dirty_slot(struct kvm *kvm, 
	return spte_set;

}



/*

 * Clears the dirty status of all the 4k SPTEs mapping GFNs for which a bit is

 * set in mask, starting at gfn. The given memslot is expected to contain all

 * the GFNs represented by set bits in the mask. If AD bits are enabled,

 * clearing the dirty status will involve clearing the dirty bit on each SPTE

 * or, if AD bits are not enabled, clearing the writable bit on each SPTE.

 */

static void clear_dirty_pt_masked(struct kvm *kvm, struct kvm_mmu_page *root,

				  gfn_t gfn, unsigned long mask, bool wrprot)

{