Commit fec3edc4 authored by Zijun Hu's avatar Zijun Hu Committed by Rob Herring (Arm)
Browse files

of/irq: Fix interrupt-map cell length check in of_irq_parse_imap_parent() 



On a malformed interrupt-map property which is shorter than expected by
1 cell, we may read bogus data past the end of the property instead of
returning an error in of_irq_parse_imap_parent().

Decrement the remaining length when skipping over the interrupt parent
phandle cell.

Fixes: 935df1bd ("of/irq: Factor out parsing of interrupt-map parent phandle+args from of_irq_parse_raw()")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20241209-of_irq_fix-v1-1-782f1419c8a1@quicinc.com


[rh: reword commit msg]
Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
parent 5d009e02

drivers/of/irq.c

+1 −0
Original line number Diff line number Diff line
@@ -111,6 +111,7 @@ const __be32 *of_irq_parse_imap_parent(const __be32 *imap, int len, struct of_ph 
	else

		np = of_find_node_by_phandle(be32_to_cpup(imap));

	imap++;

	len--;



	/* Check if not found */

	if (!np) {