Commit fefaae90 authored by Orange Kao's avatar Orange Kao Committed by Tony Luck
Browse files

EDAC/igen6: Avoid segmentation fault on module unload 

The segmentation fault happens because:

During modprobe:
1. In igen6_probe(), igen6_pvt will be allocated with kzalloc()
2. In igen6_register_mci(), mci->pvt_info will point to
   &igen6_pvt->imc[mc]

During rmmod:
1. In mci_release() in edac_mc.c, it will kfree(mci->pvt_info)
2. In igen6_remove(), it will kfree(igen6_pvt);

Fix this issue by setting mci->pvt_info to NULL to avoid the double
kfree.

Fixes: 10590a9d ("EDAC/igen6: Add EDAC driver for Intel client SoCs using IBECC")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219360


Signed-off-by: default avatarOrange Kao <orange@aiven.io>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20241104124237.124109-2-orange@aiven.io
parent f12c946e

drivers/edac/igen6_edac.c

+2 −0
Original line number Diff line number Diff line
@@ -1245,6 +1245,7 @@ static int igen6_register_mci(int mc, u64 mchbar, struct pci_dev *pdev) 
	imc->mci = mci;

	return 0;

fail3:

	mci->pvt_info = NULL;

	kfree(mci->ctl_name);

fail2:

	edac_mc_free(mci);
@@ -1269,6 +1270,7 @@ static void igen6_unregister_mcis(void) 


		edac_mc_del_mc(mci->pdev);

		kfree(mci->ctl_name);

		mci->pvt_info = NULL;

		edac_mc_free(mci);

		iounmap(imc->window);

	}