Commit ff26b2dd authored Mar 01, 2025 by Pedro Nishiyama Committed by Luiz Augusto von Dentz Mar 25, 2025

Bluetooth: Add quirk for broken READ_VOICE_SETTING



Some fake controllers cannot be initialized because they return a smaller
report than expected for READ_VOICE_SETTING.

Signed-off-by: Pedro Nishiyama <nishiyama.pedro@gmail.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

parent b9465e66

include/net/bluetooth/hci.h

+8 −0

Original line number	Diff line number	Diff line
		@@ -354,6 +354,14 @@ enum {
		* during the hdev->setup vendor callback.
		*/
		HCI_QUIRK_FIXUP_LE_EXT_ADV_REPORT_PHY,

		/* When this quirk is set, the HCI_OP_READ_VOICE_SETTING command is
		* skipped. This is required for a subset of the CSR controller clones
		* which erroneously claim to support it.
		*
		* This quirk must be set before hci_register_dev is called.
		*/
		HCI_QUIRK_BROKEN_READ_VOICE_SETTING,
		};

		/* HCI device flags */

include/net/bluetooth/hci_core.h

+4 −0

Original line number	Diff line number	Diff line
		@@ -1925,6 +1925,10 @@ void hci_conn_del_sysfs(struct hci_conn *conn);
		((dev)->commands[20] & 0x10 && \
		!test_bit(HCI_QUIRK_BROKEN_READ_ENC_KEY_SIZE, &hdev->quirks))

		#define read_voice_setting_capable(dev) \
		((dev)->commands[9] & 0x04 && \
		!test_bit(HCI_QUIRK_BROKEN_READ_VOICE_SETTING, &(dev)->quirks))

		/* Use enhanced synchronous connection if command is supported and its quirk
		* has not been set.
		*/

net/bluetooth/hci_sync.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -3696,6 +3696,9 @@ static int hci_read_local_name_sync(struct hci_dev *hdev)
		/* Read Voice Setting */
		static int hci_read_voice_setting_sync(struct hci_dev *hdev)
		{
		if (!read_voice_setting_capable(hdev))
		return 0;

		return __hci_cmd_sync_status(hdev, HCI_OP_READ_VOICE_SETTING,
		0, NULL, HCI_CMD_TIMEOUT);
		}