Commit ff2a66d2 authored by Salah Triki's avatar Salah Triki Committed by Borislav Petkov (AMD)
Browse files

EDAC/altera: Delete an inappropriate dma_free_coherent() call 



dma_free_coherent() must only be called if the corresponding
dma_alloc_coherent() call has succeeded. Calling it when the allocation fails
leads to undefined behavior.

Delete the wrong call.

  [ bp: Massage commit message. ]

Fixes: 71bcada8 ("edac: altera: Add Altera SDRAM EDAC support")
Signed-off-by: default avatarSalah Triki <salah.triki@gmail.com>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Acked-by: default avatarDinh Nguyen <dinguyen@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/aIrfzzqh4IzYtDVC@pc
parent 1b237f19

drivers/edac/altera_edac.c

+0 −1
Original line number Diff line number Diff line
@@ -128,7 +128,6 @@ static ssize_t altr_sdr_mc_err_inject_write(struct file *file, 


	ptemp = dma_alloc_coherent(mci->pdev, 16, &dma_handle, GFP_KERNEL);

	if (!ptemp) {

		dma_free_coherent(mci->pdev, 16, ptemp, dma_handle);

		edac_printk(KERN_ERR, EDAC_MC,

			    "Inject: Buffer Allocation error\n");

		return -ENOMEM;