Unverified Commit ff44b1ca authored Jan 16, 2025 by Ai Chao Committed by Ilpo Järvinen Jan 20, 2025

platform/mellanox: mlxreg-io: use sysfs_emit() instead of sprintf()



Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: Ai Chao <aichao@kylinos.cn>
Acked-by: Vadim Pasternak <vadimp@nvidia.com>
Link: https://lore.kernel.org/r/20250116081129.2902274-1-aichao@kylinos.cn


Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

parent fcf1b6f8

drivers/platform/mellanox/mlxreg-io.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -126,7 +126,7 @@ mlxreg_io_attr_show(struct device dev, struct device_attribute attr,

		mutex_unlock(&priv->io_lock);

		return sprintf(buf, "%u\n", regval);
		return sysfs_emit(buf, "%u\n", regval);

		access_error:
		mutex_unlock(&priv->io_lock);