Commit ff53a6e2 authored by Dan Williams's avatar Dan Williams Committed by Rafael J. Wysocki
Browse files

driver core: faux: Quiet probe failures 



The acpi-einj conversion to faux_device_create() leads to a noisy error
message when the error injection facility is disabled. Quiet the error as
CXL error injection via ACPI expects the module to stay loaded even if the
error injection facility is disabled.

This situation arose because CXL knows proper kernel named objects to
trigger errors against, but acpi-einj knows how to perform the error
injection. The injection mechanism is shared with non-CXL use cases. The
result is CXL now has a module dependency on einj-core.ko, and init/probe
failures are handled at runtime.

Fixes: 6cb9441b ("ACPI: APEI: EINJ: Transition to the faux device interface")
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/20250607033228.1475625-3-dan.j.williams@intel.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent c393befa

drivers/base/faux.c

+1 −1
Original line number Diff line number Diff line
@@ -170,7 +170,7 @@ struct faux_device *faux_device_create_with_groups(const char *name, 
	 * successful is almost impossible to determine by the caller.

	 */

	if (!dev->driver) {

		dev_err(dev, "probe did not succeed, tearing down the device\n");

		dev_dbg(dev, "probe did not succeed, tearing down the device\n");

		faux_device_destroy(faux_dev);

		faux_dev = NULL;

	}