Commit ffd379c1 authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe
Browse files

block: set default max segment size in case of virt_boundary 



For devices with virt_boundary limit, the driver may provide zero max
segment size, we have to set it as UINT_MAX at default. Otherwise, it
may cause warning in driver when handling sglist.

Fix it by setting default max segment size as UINT_MAX.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Mike Snitzer <snitzer@kernel.org>
Fixes: b561ea56 ("block: allow device to have both virt_boundary_mask and max segment size")
Tested-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reported-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Closes: https://lore.kernel.org/linux-block/7e38b67c-9372-a42d-41eb-abdce33d3372@linux-m68k.org/


Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20240424134722.2584284-1-ming.lei@redhat.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent fb15ffd0

block/blk-settings.c

+4 −1
Original line number Diff line number Diff line
@@ -188,7 +188,10 @@ static int blk_validate_limits(struct queue_limits *lim) 
	 * bvec and lower layer bio splitting is supposed to handle the two

	 * correctly.

	 */

	if (!lim->virt_boundary_mask) {

	if (lim->virt_boundary_mask) {

		if (!lim->max_segment_size)

			lim->max_segment_size = UINT_MAX;

	} else {

		/*

		 * The maximum segment size has an odd historic 64k default that

		 * drivers probably should override.  Just like the I/O size we