Commit ffdd27d3 authored by Qianfeng Rong's avatar Qianfeng Rong Committed by Manivannan Sadhasivam
Browse files

PCI: keystone: Use kcalloc() instead of kzalloc()

Replace calls of devm_kzalloc() with devm_kcalloc() in ks_pcie_probe().
As noted in the kernel documentation [1], open-coded multiplication in
allocator arguments is discouraged because it can lead to integer
overflow.

Using devm_kcalloc() provides built-in overflow protection, making the
memory allocation safer when calculating the allocation size compared
to explicit multiplication.

[1]: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments



Signed-off-by: default avatarQianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: default avatarManivannan Sadhasivam <mani@kernel.org>
Reviewed-by: default avatarSiddharth Vadapalli <s-vadapalli@ti.com>
Link: https://patch.msgid.link/20250819131235.152967-1-rongqianfeng@vivo.com
parent 8f5ae30d
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -1213,11 +1213,11 @@ static int ks_pcie_probe(struct platform_device *pdev)
	if (ret)
		num_lanes = 1;

	phy = devm_kzalloc(dev, sizeof(*phy) * num_lanes, GFP_KERNEL);
	phy = devm_kcalloc(dev, num_lanes, sizeof(*phy), GFP_KERNEL);
	if (!phy)
		return -ENOMEM;

	link = devm_kzalloc(dev, sizeof(*link) * num_lanes, GFP_KERNEL);
	link = devm_kcalloc(dev, num_lanes, sizeof(*link), GFP_KERNEL);
	if (!link)
		return -ENOMEM;