Commit ffe3dc5a authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: Fix eed1_8 code assigning signed values to an unsigned variable 

ia_css_eed1_8_vmem_encode() is assigning values with a range of -8192 -
8191 to e_dew_enh_y and e_dew_enh_a both of which are of the VMEM_ARRAY
type which maps to u16.

This causes the following smatch warnings:

drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c: drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c:177 ia_css_eed1_8_vmem_encode() warn: assigning (-8192) to unsigned variable 'to->e_dew_enh_y[0][base + j]'
drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c: drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c:182 ia_css_eed1_8_vmem_encode() warn: assigning (-8192) to unsigned variable 'to->e_dew_enh_a[0][base + j]'

Convert the e_dew_enh_y and e_dew_enh_a arrays to a new SVMEM_ARRAY type
which maps to s16 to fix this.

Link: https://lore.kernel.org/linux-media/20240907111701.8493-1-hdegoede@redhat.com


Reported-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
Closes: https://lore.kernel.org/linux-media/20240906081542.5cb0c142@foz.lan/


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent b36c41c5

drivers/staging/media/atomisp/pci/hive_isp_css_common/host/vmem_local.h

+3 −1
Original line number Diff line number Diff line
@@ -20,8 +20,10 @@ 
#include "vmem_global.h"



typedef u16 t_vmem_elem;

typedef s16 t_svmem_elem;



#define VMEM_ARRAY(x, s)    t_vmem_elem x[s / ISP_NWAY][ISP_NWAY]

#define VMEM_ARRAY(x, s)	t_vmem_elem x[(s) / ISP_NWAY][ISP_NWAY]

#define SVMEM_ARRAY(x, s)	t_svmem_elem x[(s) / ISP_NWAY][ISP_NWAY]



void isp_vmem_load(

    const isp_ID_t		ID,

drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8_param.h

+2 −2
Original line number Diff line number Diff line
@@ -94,8 +94,8 @@ 


struct eed1_8_vmem_params {

	VMEM_ARRAY(e_dew_enh_x, ISP_VEC_NELEMS);

	VMEM_ARRAY(e_dew_enh_y, ISP_VEC_NELEMS);

	VMEM_ARRAY(e_dew_enh_a, ISP_VEC_NELEMS);

	SVMEM_ARRAY(e_dew_enh_y, ISP_VEC_NELEMS);

	SVMEM_ARRAY(e_dew_enh_a, ISP_VEC_NELEMS);

	VMEM_ARRAY(e_dew_enh_f, ISP_VEC_NELEMS);

	VMEM_ARRAY(chgrinv_x, ISP_VEC_NELEMS);

	VMEM_ARRAY(chgrinv_a, ISP_VEC_NELEMS);